Renamed some language code dirs for consistency #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I vote for |
|
csharp sounds good |
|
Yeah, this is good. Merging. Should we also note what languages correspond to different directories somewhere? |
|
It's not a bad idea, but I don't know where we could note that. I guess as long as the dev team knows the naming scheme we're fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some languages, namely JavaScript and Haskell had code directories both called "javascript" and "js" or "haskell" and "hs" respectively. That kind of bothered me for no practical reason, so I changed it.
Because the code directories of all other languages are named after the language, not the file extension (e. g. "julia" rather than "jl"), I went for "javascript" and "haskell" over "js" and "hs".
I also renamed "R" to "r" because everything else is lowercase.
One thing I thought about chaning, but didn't, are the C# code directories. They are called "cs", after the C# file extension. I thought about renaming them to "csharp" to go with the theme. What are your thoughts on it?