Skip to content

Renamed some language code dirs for consistency #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 7, 2018
Merged

Renamed some language code dirs for consistency #224

merged 5 commits into from
Jul 7, 2018

Conversation

Butt4cak3
Copy link
Contributor

Some languages, namely JavaScript and Haskell had code directories both called "javascript" and "js" or "haskell" and "hs" respectively. That kind of bothered me for no practical reason, so I changed it.

Because the code directories of all other languages are named after the language, not the file extension (e. g. "julia" rather than "jl"), I went for "javascript" and "haskell" over "js" and "hs".

I also renamed "R" to "r" because everything else is lowercase.

One thing I thought about chaning, but didn't, are the C# code directories. They are called "cs", after the C# file extension. I thought about renaming them to "csharp" to go with the theme. What are your thoughts on it?

@zsparal
Copy link
Contributor

zsparal commented Jul 6, 2018

I vote for csharp as well, it's just more readable.

@june128
Copy link
Member

june128 commented Jul 6, 2018

csharp sounds good

Copy link
Contributor

@zsparal zsparal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this but I'd rather have @leios merge this one since it actually affects the structure of the book (or we can agree that the dev team can also merge things like this in the future).

@leios
Copy link
Member

leios commented Jul 7, 2018

Yeah, this is good. Merging.

Should we also note what languages correspond to different directories somewhere?

@leios leios merged commit 202a264 into master Jul 7, 2018
@Butt4cak3
Copy link
Contributor Author

It's not a bad idea, but I don't know where we could note that. I guess as long as the dev team knows the naming scheme we're fine for now.

@Butt4cak3 Butt4cak3 deleted the code-dirs branch July 11, 2018 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants