Adding Gaussian Elimination and Thomas Algorithm in C. #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
the
Implementation
Gathros
changed the title
| x[i] = (x[i] - a[i] * x[i - 1]) * scale; | ||
| } | ||
|
|
||
| for (int i = size - 2; i > -1; --i) { |
There was a problem hiding this comment.
My favorite way of writing reversed for loops in C is
for(int i=size-2; i-->0; ) {
Becuase it looks like it reads "i goes to zero". It is functional identical to your implementation though.
There was a problem hiding this comment.
I strongly disagree. The whole "goes to" thing is cute, but it's just obfuscating the fact that it's two separate operators. I like the concept but I'd much rather see something like:
for (int i = size - 2; i >= 0; --i) {
}Since we're not dealing with unsigned numbers this'll just work and it's a lot more clear.
This was referenced Jul 2, 2018
zsparal
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.