Tidy up code imports #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

june128 merged 4 commits into algorithm-archivists:master from Thurii:master

Jul 1, 2018

Contributor

Thurii commented Jul 1, 2018

Fixed some off-by-one errors in the markdown code imports.
Completed the tree traversal python implementation.

Thurii added 3 commits

July 1, 2018 11:10


          Fix sort code imports

ed0d3a0


          Complete python tree traversal example

12a4b31


          Fix FFT code imports

02deb32

june128 added the Implementation Edit label

VikingScientist suggested changes

View reviewed changes

Contributor

VikingScientist left a comment

Thanks for the contribution! Overall it looks good, but DFS_recursive_postorder has not been tested and is still half julia code and will need to be fixed. The new import ranges in the markdown files have been verified to be at the correct places now.

chapters/tree_traversal/code/python/Tree_example.py Outdated

+              def DFS_recursive_inorder_btree(node)
+                  if (len(node.children) == 2)
+                      DFS_recursive_inorder_btree(node.children[1])
+                      println(n.data)

Contributor

VikingScientist Jul 1, 2018

I think you mean print(...)

chapters/tree_traversal/code/python/Tree_example.py Outdated



		# This assumes only 2 children, but accounts for other possibilities
		def DFS_recursive_inorder_btree(node)

Contributor

VikingScientist Jul 1, 2018

Missing :

chapters/tree_traversal/code/python/Tree_example.py Outdated

+                      DFS_recursive_inorder_btree(node.children[1])
+                      println(n.data)
+                      DFS_recursive_inorder_btree(node.children[2])
+                  elif (len(n.children) == 1)

Contributor

VikingScientist Jul 1, 2018

node, not n

chapters/tree_traversal/code/python/Tree_example.py Outdated

+                  elif (len(n.children) == 1)
+                      DFS_recursive_inorder_btree(node.children[1])
+                      print(node.data)
+                  elif (len(n.children) == 0)

Contributor

VikingScientist Jul 1, 2018

node

chapters/tree_traversal/code/python/Tree_example.py

		@@ -34,6 +59,7 @@ def DFS_stack(node):
		for child in temp.children:
		stack.append(child)

Contributor

VikingScientist Jul 1, 2018

I don't know if it's established code style, but all other python files use single newline between functions


          Actually port the Julia code

d3845b8

Contributor Author

Thurii commented Jul 1, 2018

Thanks for catching that! I suppose it would be a good idea to try running the code before starting a PR.
The newlines are there to make it a bit easier to read and follow the PEP 8 style guide.

VikingScientist approved these changes

View reviewed changes

Contributor

VikingScientist left a comment

Great! Thanks for fixing it. Ready for merging now

Member

june128 commented Jul 1, 2018

@VikingScientist I trust your knowledge.

june128 approved these changes

View reviewed changes

june128 merged commit c481bf9 into algorithm-archivists:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Implementation Edit