thomas python example #191
Conversation
june128
added
the
Implementation
There was a problem hiding this comment.
Thanks for your contribution!
The code is, as far as I can tell, correct and should be included on trunk. There are a few minor style-issues that I would like too see changed to so it appears more consist with the rest of the python codes.
Also you'll have to fix the merge conflicts which came up after #188 was merged.
| #Author: gammison | ||
|
|
||
| #note this example is inplace and destructive | ||
| def thomas(a:list,b:list,c:list,d:list): |
There was a problem hiding this comment.
We don't use type hints elsewhere in the python code. The code should have the same style and I would request that this PR leave it out. If you strongly feel that type hints are a good thing, then either make an issue discussing it or create a brand new PR introducing it in all python codes.
| return d | ||
|
|
||
| #Complexity: | ||
| #Two loops,each take O(n), and a few contant time operations => T(n) = 2*O(n)+c*O(1) = O(n) |
There was a problem hiding this comment.
Complexity discussions should be left to the accompanying article and not in the source code. Please remove this
| c=[4,5,0] | ||
| d=[7,5,3] | ||
| soln = thomas(a,b,c,d) | ||
| print(soln) |
There was a problem hiding this comment.
Wrap execution code into a main-method. See i.e. data_compression/huffman/code/python/huffman.py
There was a problem hiding this comment.
style changes pushed
|
Merge from #188 resolved and style fixes completed |
| @@ -0,0 +1,43 @@ | |||
| #Author: gammison | |||
There was a problem hiding this comment.
All the other Python code in the project puts a space between # and the comment text.
| #Author: gammison | ||
|
|
||
| #note this example is inplace and destructive | ||
| def thomas(a,b,c,d): |
There was a problem hiding this comment.
There should be spaces after every comma in the parameter list.
| d[0] = d[0] / b[0] | ||
|
|
||
| n = len(d) #number of equations to solve | ||
| #range is exclusive, loop will run from 1 to n-1 |
There was a problem hiding this comment.
I think range() is common in enough to Python to leave this comment out.
| b=[1,3,6] | ||
| c=[4,5,0] | ||
| d=[7,5,3] | ||
| soln = thomas(a,b,c,d) |
There was a problem hiding this comment.
Again, add some spaces before and after = and after every , to be in line with all the other code examples.
|
This looks good. I have no more objections and I think it's ready for merging |
|
I agree. |
No description provided.