Skip to content

Added EditorConfig rule for Matlab and Racket source files #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2018
Merged

Added EditorConfig rule for Matlab and Racket source files #177

merged 2 commits into from
Jul 1, 2018

Conversation

Butt4cak3
Copy link
Contributor

Just that.

@Butt4cak3 Butt4cak3 requested review from leios and june128 June 29, 2018 22:08
@Butt4cak3
Copy link
Contributor Author

Wait, I'll add Racket files too.

@Butt4cak3 Butt4cak3 force-pushed the editorconfig-matlab branch from 018ad65 to fcbf0a6 Compare June 29, 2018 22:32
@Butt4cak3 Butt4cak3 changed the title Added EditorConfig rule for Matlab source files Added EditorConfig rule for Matlab and Racket source files Jun 29, 2018
@Butt4cak3 Butt4cak3 force-pushed the editorconfig-matlab branch from fcbf0a6 to b0fee37 Compare June 29, 2018 22:40
@leios
Copy link
Member

leios commented Jun 29, 2018

I guess we should have people who know matlab and racket to talk about this? I don't see any reason it would be a problem, though, so I'll approve the PR in a day if there is no discussion.

@jiegillet @VikingScientist @Unlambder

@jiegillet
Copy link
Member

No objection for matlab

@Butt4cak3
Copy link
Contributor Author

@leios I looked at the Matlab and Racket code people submitted. I didn't make the indentation rules up :p

@VikingScientist
Copy link
Contributor

Matlab looks fine 👍

@Butt4cak3
Copy link
Contributor Author

Butt4cak3 commented Jul 1, 2018 •
edited
Loading

I took the existing Matlab and Racket code examples and derived the rules from those. It's in line with what we already have. I don't know why nobody approves this PR to be honest.

Edit: Although nobody commented on Racket indentation in this comment thread, we have exactly one Racket contributor and the indentation rules I added to .editorconfig are those that @Unlambder used in the code.

@leios
Copy link
Member

leios commented Jul 1, 2018

Approved

@leios leios merged commit 15f69e0 into master Jul 1, 2018
@Butt4cak3 Butt4cak3 deleted the editorconfig-matlab branch July 6, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leios leios leios approved these changes

@june128 june128 Awaiting requested review from june128

Assignees
No one assigned
Labels
General
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Butt4cak3 @leios @jiegillet @VikingScientist