Skip to content

DFS_inorder julia update for tree traversal #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2018

Conversation

leios
Copy link
Member

@leios leios commented Jun 29, 2018

Hey guys,

To address #110, we came up with a solution in the C code for tree traversal that was basically a switch. Here is a similar solution for Julia.

Let me know what you think and if I missed anything. I kinda think the ifelse statements are a bit overkill, but that's up to you guys.

@june128 june128 added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Jun 29, 2018
@jiegillet jiegillet self-assigned this Jun 29, 2018
Copy link
Member

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's overkill, I think it's very explicit, fixes the bug and and that's good.
Since I opened #110 I'll go ahead and merge this.

@jiegillet jiegillet merged commit b9cc37e into algorithm-archivists:master Jun 29, 2018
@leios leios deleted the DFS_julia branch September 21, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants