Skip to content

Rust/Haskell/OCaml/C++ negative nums #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2017
Merged

Rust/Haskell/OCaml/C++ negative nums #17

merged 3 commits into from
Sep 19, 2017

Conversation

strega-nil
Copy link

also standardize C++ style

also standardize C++ style
@strega-nil strega-nil mentioned this pull request Sep 19, 2017
@june128
Copy link
Member

june128 commented Sep 19, 2017

I'am not quite sure, if it's better to use a -= b instead of a = a - b

@leios
Copy link
Member

leios commented Sep 19, 2017

I think we are overthinking this. The -= is standard / I am not worried about that one. I just don't like the auto and uint64_t

All other changes are great and I really appreciate it! =)

@strega-nil
Copy link
Author

strega-nil commented Sep 19, 2017

@leios I'm not sure what issue you have with auto - that's... how C++ is written. You can write C++ like C with classes, but then it's not really C++.

auto isn't confusing - the evidence, for me, is that you aren't complaining about let without types in the Rust, OCaml, or Haskell. You don't need to care about the return type of euclid, you can let the compiler figure it out for you :)

@leios
Copy link
Member

leios commented Sep 19, 2017

Wow you are quick. Thanks! =)

@leios leios merged commit 0252570 into algorithm-archivists:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants