Added Matlab bubblesort #166
Conversation
jiegillet
added
the
Implementation
|
Looks good to me! Thanks :) |
|
And another matlab script... sorry that they didn't come simultaneously |
|
Ah, terrible timing, I already approved the merge without noticing your commit. |
| retval = true; | ||
| end | ||
|
|
||
| function sorted_array = bogoe_sort(array) |
| disp(array) | ||
| end | ||
|
|
||
| function retval = is_sorted(array) |
There was a problem hiding this comment.
issorted() is built-in, maybe use that.
There was a problem hiding this comment.
Yeah know about this, but since we're teaching algorithms, it might be counterproductive to outsource too much to built-in methods. At the extreme case, you even have the sort()-function in matlab, but I don't think it would be advisable to use that one here. We just have to use individual discression in each case and for this particular case I opted to use the build-in function randperm, but not issorted.
There was a problem hiding this comment.
OK, I'm not going to insist on this one, your position is valid. It's just that, to me, the strength of matlab is the myriad of super useful built-in math functions that make your life easy. But you get it, you used randperm and I love that you implemented the shuffle that way!
is_sorted is a debatable, but using sort() would obviously defeat the purpose of implementing bubble sort :)
Are you ready to merge or are you going to snipe-commit me again?
There was a problem hiding this comment.
Ready for merging. Promise I want do any more sniping ;)
|
Yeah, you should probably not add more stuff after the fact. Next time, just open another PR. Smaller PRs are easier to review anyway. |
Inspired by #158, I decided to increase coverage for matlab