Added rust version of bogo sort #143
Conversation
| true | ||
| } | ||
|
|
||
| fn bogo_sort(arr : &mut Vec<i32>) { |
There was a problem hiding this comment.
This should take a &mut [i32] instead since you don't need any of the Vec functionality.
| } | ||
|
|
||
| fn main() { | ||
| let mut v = vec!(1,2,3,4,5); |
There was a problem hiding this comment.
I think most everyone uses let mut v = vec![1, 2, 3, 4, 5] instead of the regular parens. Also make sure to have spaces after the commas to conform to the style guide (or you can just run rustfmt)
|
|
||
| extern crate rand; | ||
|
|
||
| fn shuffle(arr : &mut Vec<i32>) { |
There was a problem hiding this comment.
rand already has a shuffle function, just use that and delete this one
|
You were faster the slice changes than I was with the review :) Edit: sorry, accidentally pushed the wrong button, didn't mean to close the PR |
|
|
||
| extern crate rand; | ||
|
|
||
| fn shuffle(arr : &mut [i32]) { |
There was a problem hiding this comment.
You still don't really need this function, just use the one that rand provides.
|
@Gustorn Pretty sure you're the only active contributor who knows Rust well enough. |
|
Fair enough |
No description provided.