Added the java version of the bubble algorithm #131

xam4lor · 2018-06-27T18:28:11Z

No description provided.

Gathros · 2018-06-27T18:44:22Z

Can you add an example like this.

xam4lor · 2018-06-27T19:04:36Z

In Java we must have all of the code inside a class like this example :

package test;

public class Main {
	public static void main(String[] args) {
             // blabla
        }
}

Should I add the class structure or just the functions inside it ?
(Sorry for my bad English, I'm French ;) )

Gathros · 2018-06-27T19:33:02Z

Just wrap a class around main and BubbleSort so it's executable.

Butt4cak3

Welcome @xam4lor! Thanks for your code contribution. Java didn't get much love in the AAA yet, so I'm happy to see someone add a few algorithms for it.

I see, you and @Gathros have already improved a few things about your PR. I, too, have some things that I'd like you to change. Most of them are more of a style-guide kind of deal.

First off, I noticed that you used tabs in your code. There is nothing inherently bad about that, don't get me wrong, but all the other Java code in the Algorithm Archive already uses 4 spaces instead and we like to keep things consistent. There are also some places in both .java files where you use tabs and spaces. You should clean that up.

Butt4cak3 · 2018-06-27T20:19:52Z

chapters/sorting_searching/bogo/code/java/bogo.java

+
+	    System.out.println("\n\nSorted array :");
+	    for (int i = 0; i < test.length; i++) {
+			System.out.print(test[i] + " ");


You use System.out.print() here, which is fine to print the list, but you should add an empty System.out.println() or System.out.print("\n") at the end so that there's a line break in the end. Otherwise the output looks like this (at least on Linux):

marius@DasPC:java> java Bubble Unsorted array : 20 -3 50 1 -6 59 Sorted array : -6 -3 1 20 50 59 marius@DasPC:java>

See how the prompt marius@DasPC:java> is on the same line as the last line of output?

Butt4cak3 · 2018-06-27T20:23:05Z

chapters/sorting_searching/bogo/code/java/bogo.java

@@ -0,0 +1,47 @@
+public class Bogo {
+	// The shuffle() function can be found in code/java/bogo.java


We are already in code/java/bogo.java.

That was for the website implementation ! The user don't see the shuffle() methode !

Butt4cak3 · 2018-06-27T20:38:59Z

@xam4lor Hold on there for a second! I recommend not adding more and more stuff to this pull request. The more algorithms you add, the more clustered the conversation will be and the harder it will be to review the pull request.

Bubble Sort and Bogo Sort in one PR is fine, but I recommend creating separate PRs for separate algorithms. Otherwise it will take ages to get this merged.

Alternatively, you can add a few algorithms and we'll wait until you're done with all of them. Then we can review all of them at once. In that case, just add stuff and when you're done with everything, mention me with @Butt4cak3 and I'll get back to you.

Your call.

june128 · 2018-06-27T20:39:43Z

@xam4lor Do you mind to move the C# commit into a separate PR?

Butt4cak3 · 2018-06-27T20:44:22Z

Oh... I thought the newest commit was also Java, but it's actually C#. Yeah, you should definitely not add multiple algorithms in different languages to one pull request. If you have any questions on how to split things up properly, ask me here, or even better, hop over to our Discord (linked in the README of this repo) and ask there.

xam4lor · 2018-06-27T20:52:40Z

Okay okay 🤣
I'm really new with opensource projects !!
Can somebody clean and split all of the requests and things and make the good changes please ??

june128 · 2018-06-27T20:54:25Z

@xam4lor do you mind joining https://discord.gg/2kWgSWB ?
I don't know, if we can actually split things up or if you need to do so. (@Butt4cak3 ?)

Added an empty println() at the end and put spaces instead of tabs.

Butt4cak3

Alright. Now that we have the technical stuff figured out, I made a proper review for the code. I can't find anything inherently wrong with it.

I noticed that you basically just ported my JavaScript code to Java, but that's perfectly fine. That's actually pretty good, because now the implementations in different languages are more like each other, just tweaked for the respective language.

Once you fix the three things I commented, this one is ready to merge.

Butt4cak3 · 2018-06-27T23:35:43Z

chapters/sorting_searching/bogo/code/java/bogo.java

+        for (int i = 0; i < test.length; i++) {
+            System.out.print(test[i] + " ");
+        }
+	System.out.println("\n");


You don't need both println and "\n". println already automatically adds a "\n" at the end of the string. Using System.out.println("\n") will actually print two line breaks.

Go for either System.out.print("\n") or System.out.println(). I prefer the latter, but it's up to you.

I don't really know if it's better with one or two spaces ...

Butt4cak3 · 2018-06-27T23:37:34Z

chapters/sorting_searching/bubble/code/java/bubble.java

@@ -0,0 +1,31 @@
+public class Bubble {
+	static void bubbleSort(int[] arr) {


This entire file is still indented with tabs. Again, not inherently bad, but you should replace these with 4 spaces each for consistency.

Butt4cak3 · 2018-06-27T23:41:22Z

chapters/sorting_searching/bubble/code/java/bubble.java

+	    System.out.println("\n\nSorted array :");
+	    for (int i = 0; i < test.length; i++) {
+			System.out.print(test[i] + " ");
+		}


Add an empty System.out.println() here to fix the output, just as in bogo.java.

xam4lor · 2018-06-28T08:58:43Z

So I think it's better if all of the codes are the same in the way of thinking, because the user can compare different languages !

Butt4cak3 · 2018-06-28T22:00:25Z

Everything is looking good now. Let's merge and then realize what a massive mistake we have done! \o/

Add the java version of the bubble algorithm

011fbf1

Gathros added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Jun 27, 2018

xam4lor added 2 commits June 27, 2018 20:41

Added contribution and modified markdown file

3e5fdff

Update bubble_sort.md

883be3b

Added some example code

3113eb4

Added Bogo example and wrapped class for Bubble ex

00ae3c3

Butt4cak3 requested changes Jun 27, 2018

View reviewed changes

Butt4cak3 reviewed Jun 27, 2018

View reviewed changes

Update bogo.java

e1f6d43

Added an empty println() at the end and put spaces instead of tabs.

Butt4cak3 requested changes Jun 27, 2018

View reviewed changes

xam4lor added 3 commits June 28, 2018 10:53

Update bogo.java

f58d817

Replace tabs with spaces

4b965fd

Added an empty sysout at the end

cf065a8

Merge branch 'master' into java-language-implementation

308296c

Butt4cak3 self-assigned this Jun 28, 2018

Butt4cak3 approved these changes Jun 28, 2018

View reviewed changes

Merge branch 'master' into java-language-implementation

f991753

Butt4cak3 merged commit 64a9d0f into algorithm-archivists:master Jun 28, 2018

xam4lor deleted the java-language-implementation branch June 29, 2018 14:08

		@@ -0,0 +1,47 @@
		public class Bogo {
		// The shuffle() function can be found in code/java/bogo.java

		@@ -0,0 +1,31 @@
		public class Bubble {
		static void bubbleSort(int[] arr) {

Uh oh!

Added the java version of the bubble algorithm #131

Added the java version of the bubble algorithm #131

Uh oh!

Conversation

xam4lor commented Jun 27, 2018

Uh oh!

Gathros commented Jun 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xam4lor commented Jun 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gathros commented Jun 27, 2018

Uh oh!

Butt4cak3 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Butt4cak3 Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

Butt4cak3 Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

xam4lor Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

Butt4cak3 commented Jun 27, 2018

Uh oh!

june128 commented Jun 27, 2018

Uh oh!

Butt4cak3 commented Jun 27, 2018

Uh oh!

xam4lor commented Jun 27, 2018

Uh oh!

june128 commented Jun 27, 2018

Uh oh!

Butt4cak3 left a comment

Choose a reason for hiding this comment

Uh oh!

Butt4cak3 Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

xam4lor Jun 28, 2018

Choose a reason for hiding this comment

Uh oh!

Butt4cak3 Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

Butt4cak3 Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

xam4lor commented Jun 28, 2018

Uh oh!

Butt4cak3 commented Jun 28, 2018

Uh oh!

Uh oh!

Gathros commented Jun 27, 2018 •

edited

Loading

xam4lor commented Jun 27, 2018 •

edited

Loading

Butt4cak3 left a comment •

edited

Loading