Adding graham.c #106
Merged
Adding graham.c #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
the
Implementation
zsparal
reviewed
May 12, 2018
| }; | ||
|
|
||
| int cmp_points(const void *a, const void *b) { | ||
| struct point point1 = *(struct point*)a; |
There was a problem hiding this comment.
You shouldn't copy the points, it's completely unnecessary. Just cast to struct point* and compare them that way
zsparal
reviewed
May 12, 2018
| } | ||
| } | ||
|
|
||
| double ccw(struct point a, struct point b, struct point c) { |
There was a problem hiding this comment.
I don't think ccw is the best name here. That would make sense if it returned a bool. I'd probably call it orientation or something like that.
|
@Gustorn I changed |
zsparal
reviewed
May 12, 2018
| }; | ||
|
|
||
| int cmp_points(const void *a, const void *b) { | ||
| if (((struct point*)a)->y > ((struct point*)b)->y) { |
There was a problem hiding this comment.
Having them as variables wasn't a bad idea, I just didn't like the copy:
struct point* pa = (struct point*) a;
struct point* pb = (struct point*) b;
if (pa->y > pb->y) {
// ...
zsparal
approved these changes
May 14, 2018
zsparal
approved these changes
May 14, 2018
|
Since @Gustorn approved it, it should be fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.