Update blame view upon save #31
Conversation
Fixes alexcorre#29. Test plan: First test editing when view is open: * Open blame * Add some newlines * Save file * See blame view update Now test it updates upon second display: * Open blame * Close blame * Add some newlines * Save file * Open blame again * See it update
|
This isnt working for me. Pulled down your branch on my machine and am testing it out. It appears we are indeed calling setState with the new blame data on a save but the blame UI is not updating. Even after closing and opening. Running atom 0.124.0 |
|
Weird, let me test it out again. |
In the last commit I think I simplified the code and tricked myself into thinking I tested it, but I must have not reloaded the package. This commit works though. Test plan: First test editing when view is open: * Open blame * Add some newlines * Save file * See blame view update Now test it updates upon second display: * Open blame * Close blame * Add some newlines * Save file * Open blame again * See it update
|
Ok, fixed it. Sorry about that. I think I tested it before doing a cleanup pass. My cleanup broke it, but somehow I didn't test again before opening the PR. Maybe I forgot to reload the Atom window or something. While doing this I also noticed a bug in #32 which I have fixed here... I guess the night I opened those PRs wasn't a good one for coding. |
Not sure what happened when I tried to do this in 39133b1, but evaluating `DEFAULT_DATE` at import time doesn't work because `atom.config.get` returns undefined. So calculate it later and cache it. Test Plan: Reloaded window then opened blame in a big file. Saw my preferred datestring and not the full ISO 8601 format.
dmnd
force-pushed
the
update-upon-save
branch
from
6ee8b6a to
26e3e1c
Compare
|
BTW, this PR is a pretty heavyweight way to update the blame view. It calls blame again on the entire file so it can be slow on large files with complex histories. We could definitely make this faster if we stored the blame data for the unmodified file, then incrementally updated it based on the changes that have been made to the file. I decided that this was good enough for now though. |
Fixes #29.
Test plan:
First test editing when view is open:
Now test it updates upon second display: