Skip to content

[PEGASUS-932] Redact JWT token from logs #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2020
Merged

[PEGASUS-932] Redact JWT token from logs #158

merged 2 commits into from
Jun 25, 2020

Conversation

thekindofme
Copy link
Contributor

Context

https://zendesk.atlassian.net/browse/PEGASUS-932

We are logging sensitive information, such as Zendesk JWT Tokens as well as agent and customer PII, to var/log/zendesk.log in plaintext on the server hosting the Magento installation. We have ranked this as a Moderate vulnerability based on that it required malicious access to the server in question to exploit.

Link: https://support.zendesk.com/agent/tickets/5475611

@thekindofme thekindofme merged commit 8e8b89f into master Jun 25, 2020
@thekindofme thekindofme deleted the yfernando/remove-jwt-token-from-logs branch June 25, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshdog yoshdog yoshdog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekindofme @yoshdog