Fixes for Rust Composites #921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeron-io#1: LibRsDef explicitly us crate:: to disambiguate from built in mods like bool aeron-io#2: Added acting_version field to Composite structs to fix compilation errors when using Composite structs. This is an incomplete implementation because the parent doesn't pass the acting_version to the composite because you need to change the signature of wrap(parent, offset) to include the acting_version, so this version just ensures that if the acting_version isn't set on the composite, it disregards the version check. aeron-io#3: fixed primitiveArrayDecoder to return an empty array of the right size if less than version required.
|
This is failing the CI tests, please could you look into the failures and make the necessary corrections. |
|
@adam-talos The build fails with the CheckStyle errors: |
|
@adam-talos This PR has merge conflicts and failing tests. Are you going to fix it or shall we close it? |
I've switched projects and don't have time to address this issue so you can close it. If I have time to polish it, I can resubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed several issues:
1: LibRsDef explicitly use crate:: to disambiguate from built in mods like bool
2: Added acting_version field to Composite structs to fix compilation errors when using Composite structs. This is an incomplete implementation because the parent doesn't pass the acting_version to the composite because you need to change the signature of wrap(parent, offset) to include the acting_version, so this version just ensures that if the acting_version isn't set on the composite, it disregards the version check.
3: fixed primitiveArrayDecoder to return an empty array of the right size if less than version required.
4: If a name of an element clashes with a rust type, prefix it with r#, which is the preferred way of dealing with clashes with keywords