Skip to content

Header validation warning on non-uint16 types instead of error #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Header validation warning on non-uint16 types instead of error #629

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e42423
Header validation warning on non-uint16 types instead of error
Jan 30, 2019
aa9685a
grammar on warn
Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ else if (blockLengthType.primitiveType() != UINT16)
}
else if (templateIdType.primitiveType() != UINT16)
{
XmlSchemaParser.handleError(node, "\"templateId\" must be UINT16");
XmlSchemaParser.handleWarning(node, "\"templateId\" should be UINT16");
}

if (schemaIdType == null)
Expand All @@ -332,7 +332,7 @@ else if (templateIdType.primitiveType() != UINT16)
}
else if (schemaIdType.primitiveType() != UINT16)
{
XmlSchemaParser.handleError(node, "\"schemaId\" must be UINT16");
XmlSchemaParser.handleWarning(node, "\"schemaId\" should be UINT16");
}

if (versionType == null)
Expand All @@ -341,7 +341,7 @@ else if (schemaIdType.primitiveType() != UINT16)
}
else if (versionType.primitiveType() != UINT16)
{
XmlSchemaParser.handleError(node, "\"version\" must be UINT16");
XmlSchemaParser.handleWarning(node, "\"version\" should be UINT16");
}
}

Expand Down