Skip to content

otf_api is too strict about version comparison #970

Closed
@aschw

Description

@aschw

Line 114 of IrDecoder.h reads:

if (token.signal() == Signal::BEGIN_MESSAGE && token.fieldId() == id && token.tokenVersion() == version)

I haven't traced out the path from xml to sbeir to cpp, but I'm pretty sure that token.tokenVersion() comes from the XML's sinceVersion field. If so, a strict version match is not appropriate. I think the version check should be changed to an inequality.

if (token.signal() == Signal::BEGIN_MESSAGE && token.fieldId() == id && token.tokenVersion() <= version)

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions