Skip to content

Remove code for unnecessary Adafruit SAMD Boards platform dependency #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Remove code for unnecessary Adafruit SAMD Boards platform dependency #76

merged 1 commit into from
Jun 7, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 6, 2020

Previously, Arduino SAMD Boards was installed whenever the script was run for one of the Adafruit SAMD Boards.

Adafruit SAMD Boards doesn't have a dependency on Arduino SAMD Boards, so this only slows down the CI run.

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.
    This will help us understand any risks of integrating
    the code.

I removed the code that installs Arduino SAMD Boards whenever the code is being compiled for one of the Adafruit SAMD Boards.

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it.

This change would only cause a problem if Adafruit SAMD Boards changed to having a dependency on Arduino SAMD Boards at some point in the future.

  • Please run any tests or examples that can exercise your modified code. We
    strive to not break users of the code and running tests/examples helps with this
    process.

I have tested this in my fork:
https://github.com/per1234/ci-arduino/runs/745991258?check_suite_focus=true#step:5:28
I notice this repository's GitHub Actions workflow doesn't test the script for any Adafruit boards. If you would like me to add one of the Adafruit SAMD Boards to the workflow to verify this PR, I'm happy to do so.

Adafruit SAMD Boards doesn't have a dependency on Arduino SAMD Boards, so this only slows down the CI run.
@ladyada ladyada merged commit 44550ac into adafruit:master Jun 7, 2020
@ladyada
Copy link
Member

ladyada commented Jun 7, 2020

thanks will try it! :)

@per1234 per1234 deleted the remove-arduinosamd-dependency branch June 7, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants