Remove code for unnecessary Adafruit SAMD Boards platform dependency #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Arduino SAMD Boards was installed whenever the script was run for one of the Adafruit SAMD Boards.
Adafruit SAMD Boards doesn't have a dependency on Arduino SAMD Boards, so this only slows down the CI run.
of the code were modified. This will help us understand any risks of integrating
the code.
I removed the code that installs Arduino SAMD Boards whenever the code is being compiled for one of the Adafruit SAMD Boards.
doesn't apply to a supported platform of the library please mention it.
This change would only cause a problem if Adafruit SAMD Boards changed to having a dependency on Arduino SAMD Boards at some point in the future.
strive to not break users of the code and running tests/examples helps with this
process.
I have tested this in my fork:
https://github.com/per1234/ci-arduino/runs/745991258?check_suite_focus=true#step:5:28
I notice this repository's GitHub Actions workflow doesn't test the script for any Adafruit boards. If you would like me to add one of the Adafruit SAMD Boards to the workflow to verify this PR, I'm happy to do so.