Skip to content

Documentation for Client.py (API Client) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 31, 2018
Merged

Documentation for Client.py (API Client) #78

merged 3 commits into from
Dec 31, 2018

Conversation

brentru
Copy link
Member

@brentru brentru commented Dec 26, 2018

Cleanup of client.py, the API Client for IO:

  • Methods now have RTD-style comments
  • Updated method docstrings.
  • Slowed down travis to prevent throttling on builds causing errors

@brentru brentru requested a review from abachman December 26, 2018 17:46
jerryneedell
jerryneedell requested changes Dec 31, 2018
View reviewed changes
Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one concern about a potential breaking change. I think this requires some updates to the examples.

jerryneedell
jerryneedell approved these changes Dec 31, 2018
View reviewed changes
Copy link

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I recommend a note in the release notes about the breaking change to send_location_data.

@brentru brentru merged commit 19f8cea into adafruit:master Dec 31, 2018
@brentru brentru deleted the rtd-comments branch December 31, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell approved these changes

@abachman abachman Awaiting requested review from abachman

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @jerryneedell