Made #14 pass #23
Merged
Made #14 pass #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@dherrada heya can you test this out with some hardware? what displays/eink/LED matricies do you have? |
|
@ladyada, I'll do that rn |
siddacious
suggested changes
Oct 20, 2019
adafruit_framebuf.py
Outdated
| def draw_char(self, char, x, y, framebuffer, color): | ||
| # pylint: disable=too-many-arguments | ||
| # pylint: disable=too-many-arguments | ||
| def draw_char(self, char, x, y, framebuffer, color, size=1): |
There was a problem hiding this comment.
add the disable to the end of the def line and it will be scoped to this function only. Otherwise put an enable after the function.
siddacious
approved these changes
Oct 21, 2019
|
Looks bueno. |
|
@dherrada did ya get to testing this? |
|
@ladyada, yes, I did. The simple test needed some fixing so I did that, but the framebuf module itself was fine |
|
@ladyada sorry I should have mentioned @dherrada tested it when I merged |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 22, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.5.0 from 2.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#33 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_EPD#32 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_EPD#29 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#24 from boo13/draw-circle > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#23 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#22 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_MCP9600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TG-Techie, I'm not sure why sphinx kept failing over that docstring, and I'm even less sure about how just adding a newline would make it pass, but it passes locally now.
This PR is a fix of a really weird issue from #14