-
Notifications
You must be signed in to change notification settings - Fork 14
Add ValueError to start_range_continuous() #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactors `start_range_continuous()` and also adds throwing ValueError if out of range.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. I don't have the specific hardware for testing.
@tekktrik did you run this with the sensor?
I don't think I did but I can. Looking at this again I suspect the faulty range was a typo. I'll comment here once it's tested, at some point today if I can find the sensor if I can't find it now. |
Just kidding, can't find it, whoops |
Revisiting, I haven't forgotten about this. Though I do seem to have forgotten where I put my sensor haha. Pretty sure the original was a typo but worst case I'll order another sensor. |
Can confirm, it was a typo 🥲 |
@FoamyGuy is this good to merge? Didn't know if your approval was contingent on test. |
@tekktrik it would be best to test if we can. I've got one of these sensors now. I'll test it this week |
I tested successfully with a PyPortal Titano connected with a stemma cable to the VL6180. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.4.4 from 1.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#28 from tekktrik/dev/fix-setting-delay > change discord badge > Patch: Replaced discord badge image > Updated gitignore
Refactors
start_range_continuous()
and also adds throwing ValueError if out of range. Not sure why the period couldn't be set specifically between 2.25 and 2.54 seconds, but that was also removed and can now be done (in the 10 ms intervals)Also updates the documentation to add more information on the delay behavior.