Add range status check #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 1, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_floppy to 1.0.2 from 1.0.1: > Set language to "en" for documentation > Merge pull request adafruit/Adafruit_CircuitPython_floppy#4 from tekktrik/dev/lint-example > Update .pre-commit-config.yaml > Fix Docs badge > fix discord link for RTD > fix python version for rtd Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.3.1 from 4.3.0: > Set language to "en" for documentation > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#99 from makermelissa/master > Switch to inclusive terminology > Increase min lines similarity > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X to 1.1.2 from 1.1.1: > Set language to "en" for documentation > Merge pull request adafruit/Adafruit_CircuitPython_VL53L1X#8 from caternuson/iss7_range_check > Increase min lines similarity > Patch .pre-commit-config.yaml Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.6 from 1.12.5: > Set language to "en" for documentation > Switch to inclusive terminology > Increase min lines similarity > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#58 from rstein/fix_sending_when_offset_greater_than_socksize > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Update .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.3.2 from 8.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#167 from tekktrik/doc/hyperspecific-targets Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.7 from 1.2.6: > Set language to "en" for documentation > Merge pull request adafruit/Adafruit_CircuitPython_JWT#14 from Neradoc/add-deps > Switch to inclusive terminology > Increase min lines similarity > Patch .pre-commit-config.yaml Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_floppy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for #7.
The
distancewill now returnNoneif range status is anything other than "valid".For now, check is simple and hard coded. In the future, could expand this out to check for other fail modes and report them back in some manor. Note that the values defined for status:
are not the same value as the register. See mapping in switch statement here:
https://github.com/adafruit/Adafruit_VL53L1X/blob/f2aaac89649823876451751a43cd1b036d65b22f/src/vl53l1x_class.cpp#L600-L644
That was used to determine that
0x09register value is0range status, aka,VL53L1_RANGESTATUS_RANGE_VALID.