Fix time conversion in measurement_timing_budget #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested! seems good to me :) |
|
ok back from tacos, did a release - will have mpys shortly! |
|
rlake, i just did some improvements and another relaese, should be smaller, faster! |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 13, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.0.5 from 3.0.4: > be exact about length of byte array matching what we're unpacking (CPython cares!) Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.1.3 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#7 from ladyada/master > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#6 from rlake/time_conversion
|
tried out the release version. works great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Important note: I've been unable to test (mpy version conflict issues) so this is just a direct conversion from the pololu code. It kinda feels like there should be a subtract in there so that's weird.