Added sensor name to example file name #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dherrada Please include |
|
@dherrada Please check that you're providing the correct path in the docs https://travis-ci.com/adafruit/Adafruit_CircuitPython_VC0706/builds/110796673#L633 |
|
Docs look good - thanks! Please include |
brentru
reviewed
May 8, 2019
docs/examples.rst
Outdated
| .. literalinclude:: ../examples/snapshot.py | ||
| :caption: examples/snapshot.py | ||
| .. literalinclude:: ../examples/vc0706_snapshot_simpletest.py | ||
| :caption: examples/vc0706_snapshot.py |
There was a problem hiding this comment.
@dherrada Please change this to vc0706_snapshot_simpletest, Line #11
|
Done |
|
Thanks @dherrada, looks good. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 9, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 4.0.3 from 4.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#8 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.1.4 from 0.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#10 from brentru/add-nina-fw-esptool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.