a little refactoring, speed-up, and CPython compatibility #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead_picture_into (yay faster), CPython compatible with example removed: initialization args have been change, only pass in a uart now!
|
passing travis & ready for review! |
tannewt
requested changes
Aug 21, 2018
adafruit_vc0706.py
Outdated
| for _ in range(2): # 2 retries to reset then check resetted baudrate | ||
| for baud in (9600, 19200, 38400, 57600, 115200): | ||
| self._uart.baudrate = baud | ||
| if self._run_command(_RESET, bytes([0x00]), 5): |
There was a problem hiding this comment.
Instead of bytes([0x00]) do b'\x00'. That way it doesn't need to create a list to convert to bytes.
adafruit_vc0706.py
Outdated
| :param ~microcontroller.Pin tx: Transmit pin | ||
| :param int baudrate: Serial connection speed | ||
| :param int timeout: Read timeout in seconds | ||
| :param int buffer_size: Receive buffer size |
There was a problem hiding this comment.
I'd suggest updating this, not just deleting it. It makes for nicely formatted docs: https://circuitpython.readthedocs.io/projects/vc0706/en/latest/api.html#adafruit_vc0706.VC0706
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 21, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#8 from ladyada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 4.0.0 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#5 from ladyada/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added: auto-detect baudrate, allow baudrate change, no flush during read_picture_into (yay faster), CPython compatible with example
removed: initialization args have been change, only pass in a uart now!
tested on feather m4 w/wing and internal FS
API changed so we'll need a large version bump. but it was terribly slow before