Skip to content

Define BlockDevice class for VfsFat block device arguments #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2023
Merged

Define BlockDevice class for VfsFat block device arguments #30

merged 5 commits into from
Mar 20, 2023

Conversation

isacben
Copy link
Contributor

@isacben isacben commented Mar 19, 2023 •
edited
Loading

Hi,

I'm opening this PR to try to solve the following issue in the CircuitPython repository:

#7741 Define abstract "block device" type for use in VfsFat and elsewhere

Please let me know if I am heading to the right direction.

Thanks!

@isacben isacben mentioned this pull request Mar 19, 2023
Merged
@tannewt tannewt requested a review from dhalbert March 20, 2023 21:32
dhalbert
dhalbert approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this looks good! It is exactly what I had in mind.

@dhalbert dhalbert merged commit 6a78016 into adafruit:main Mar 20, 2023
@dhalbert dhalbert mentioned this pull request Mar 21, 2023
Closed
@isacben
Copy link
Contributor Author

isacben commented Mar 21, 2023

Thank you, Dan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isacben @dhalbert