Skip to content

fix error for packets with payloads > 7 bytes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2019
Merged

fix error for packets with payloads > 7 bytes #20

merged 1 commit into from
Feb 11, 2019

Conversation

jerryneedell
Copy link
Contributor

fixes #19

@jerryneedell jerryneedell requested a review from brentru February 9, 2019 22:24
@brentru
Copy link
Member

brentru commented Feb 11, 2019

@jerryneedell Looks good, just tested with a 19b payload:

Packet: bytearray(b"\x00\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16\x17\x18")
TTN Console RX: 00010203040506070809101112131415161718

@brentru brentru merged commit 4e9eebc into adafruit:master Feb 11, 2019
@jerryneedell jerryneedell deleted the jerryn_big_packet branch February 11, 2019 15:32
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 11, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@5ea5ed2)
ee73fcb 
Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.2.2 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#15 from ArthurDent62/ArthurDent62-exceptionNotAssert

Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 1.0.8 from 1.0.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#20 from jerryneedell/jerryn_big_packet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru Awaiting requested review from brentru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TTN: Payload is not forwarded to the Application when the payload has more than seven bytes
2 participants
@jerryneedell @brentru