Adds initial working code. #2
Conversation
.pylintrc
Outdated
| # (useful for modules/projects where namespaces are manipulated during runtime | ||
| # and thus existing member attributes cannot be deduced by static analysis. It | ||
| # supports qualified module names, as well as Unix pattern matching. | ||
| ignored-modules= |
There was a problem hiding this comment.
While a patch is in work to do this, can you add board to the ignored-modules? This will cover future PyPi work.
.travis.yml
Outdated
|
|
||
| install: | ||
| - pip install pylint circuitpython-build-tools Sphinx sphinx-rtd-theme | ||
|
|
There was a problem hiding this comment.
Could you change this to:
- pip install circuitpython-build-tools Sphinx sphinx-rtd-theme
- pip install --force-reinstall pylint==1.9.2
While pylint is currently happy, who knows what will get added in future versions. 😄
adafruit_tca9548a.py
Outdated
| self.i2c = i2c | ||
| self.address = address | ||
| self.used_channels = [] | ||
|
|
There was a problem hiding this comment.
Add:
def __len__(self):
return 8That way it can be iterated over.
adafruit_tca9548a.py
Outdated
|
|
||
| def __getitem__(self, key): | ||
| if not 0 <= key <= 7: | ||
| raise ValueError("Channel must be an integer in the range: 0-7") |
There was a problem hiding this comment.
IndexError instead since its a sequence.
adafruit_tca9548a.py
Outdated
| if not 0 <= key <= 7: | ||
| raise ValueError("Channel must be an integer in the range: 0-7") | ||
| if key in self.used_channels: | ||
| raise ValueError("Channel already in use.") |
There was a problem hiding this comment.
I wouldn't track this because you could have multiple devices on a single channel. The locking should prevent bus usage conflicts.
adafruit_tca9548a.py
Outdated
| if key in self.used_channels: | ||
| raise ValueError("Channel already in use.") | ||
| self.used_channels.append(key) | ||
| return TCA9548A_Channel(self, key) |
There was a problem hiding this comment.
I would cache the channel so the same object is returned for the same accesses.
requirements.txt
Outdated
| @@ -0,0 +1 @@ | |||
| adafruit-circuitpython-busdevice | |||
There was a problem hiding this comment.
This isn't a dependency because its not imported by adafruit_tca9548c.py.
See
examples/tca9548a_simpletest.pyfor example usage.