Skip to content

Expose serial number & device type properties #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

Expose serial number & device type properties #21

merged 1 commit into from
Jan 25, 2021

Conversation

imgrant
Copy link
Contributor

@imgrant imgrant commented Jan 25, 2021

ladyada
ladyada requested changes Jan 25, 2021
View reviewed changes
@ladyada
Copy link
Member

ladyada commented Jan 25, 2021

please check the suggestions, also run pylint and black :)
https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

@imgrant
Copy link
Contributor Author

imgrant commented Jan 25, 2021 •
edited
Loading

please check the suggestions, also run pylint and black :)
https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

Thanks, I've pushed the return & formatting changes
Edit: I spoke too soon, I will fixup the pylint complaints that I now see in the CI output

@ladyada
Copy link
Member

ladyada commented Jan 25, 2021

please check CI and the guide until you get a green check - then tag me for a final review :)

@imgrant
Expose serial number & device type properties.
0836aab 
Routines taken from Chris Balmer's Si7021 MicroPython driver.
@imgrant
Copy link
Contributor Author

imgrant commented Jan 25, 2021

Thanks for the tips @ladyada CI has passed now!

@ladyada
Copy link
Member

ladyada commented Jan 25, 2021

@imgrant awesome, can you tell me what hardware you used to test?

@imgrant
Copy link
Contributor Author

imgrant commented Jan 25, 2021

@imgrant awesome, can you tell me what hardware you used to test?

An Adafruit Si7021 breakout board (the older generation, without STEMMA QT/Qwic connectors), and a Raspberry Pi (3B)

@ladyada
Copy link
Member

ladyada commented Jan 25, 2021

kk im not going to test with hardware cause it looks OK to me, we'll see if anyone has issues!

@ladyada ladyada merged commit 774eabc into adafruit:master Jan 25, 2021
@anecdata
Copy link
Member

Tested on PyPortal with Stemma QT version of Si7021, looks good.

@ladyada
Copy link
Member

ladyada commented Jan 25, 2021

thank you @anecdata!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 26, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@0b83e6e)
5298b5f 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Nunchuk to 0.3.0 from 0.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Nunchuk#20 from caternuson/i2c_speedup
  > Merge pull request adafruit/Adafruit_CircuitPython_Nunchuk#14 from caternuson/iss13

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to v3.3.0 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#21 from imgrant/serial_number

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.1.1 from 0.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#2 from ryang14/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imgrant @ladyada @anecdata