Fixes issues #4, #6 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jul 15, 2019
|
your testing sounds good, will merge! |
|
@siddacious plz bump a release |
This was referenced Jul 28, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 28, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.1.4 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#7 from phrogger/phrogger_assert_fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses open issues #4 and #6 for "adafruit_si5351.py"
line 214: changed
assert 0 < denominator < 0xFFFFF
to
assert 0 < denominator <= 0xFFFFF
because 0xFFFFF = 1048575 is a valid pll fractional denominator
per AN619, page 3.
Addresses issue #6 opened July 14 by phrogger
line 298: changed
assert 0 <= divider <= 6
to
assert 0 <= divider <= 7
because R_DIV_128 corresponding to index 7 is valid.
Addresses issue #4 opened on Mar 24 by evbaarle
line 350: changed
assert 0 < denominator < 0xFFFFF
to
assert 0 < denominator <= 0xFFFFF
because 0xFFFFF = 1048575 is a valid output fractional denominator
per AN619, page 6.
Same bug, different location, as issue #6 opened July 14 by phrogger
The changes were tested by running CP 4.0.2 on a Feather M4 Express with the
changes in a file "adafruit_si5351.py", and verified to work as expected.
The changes were not built into an ".mpy" file locally and verified.
Considering the changes, the risk is low.
If this is a necessary part of testing before a pull-request is accepted,
reject this pull request, and I will figure out how to do that.
--- Graham / phrogger