Added support for newer SGP30 chips which use a featureset value of 0x0022 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
requested changes
Oct 18, 2019
adafruit_sgp30.py
Outdated
| @@ -51,7 +51,7 @@ | |||
|
|
|||
| # pylint: disable=bad-whitespace | |||
| _SGP30_DEFAULT_I2C_ADDR = const(0x58) | |||
| _SGP30_FEATURESET = const(0x0020) | |||
| _SGP30_FEATURESETS = [const(0x0020), const(0x0022)] | |||
There was a problem hiding this comment.
ooh ok thats a way to do it -if so, please remove the const()'s and turn this into a tuple ()
There was a problem hiding this comment.
Ah, ok! I’m pretty clearly not a python guy, plus that was code from 5pm on a Friday. :-\ I now understand that tuples are immutable (and apparently faster) and thus a much better choice here. Will do, thanks! :-)
ladyada
approved these changes
Nov 6, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 13, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.5.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#38 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#39 from adafruit/revert-36-bitbangio > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#36 from schelmo/bitbangio > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#35 from schelmo/digitalio Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.4 from 3.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#56 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#55 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#39 from kevinjwalters/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.1.0 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#20 from Airviz/multiple-featureset-values > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#18 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#4 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.9.2 from 0.9.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#8 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#6 from adafruit/dherrada-patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue 19