fix potential byte overflow exceptions #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
May 11, 2019
|
FYI, didnt test but looks good to me |
dhalbert
approved these changes
May 11, 2019
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 12, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.2.3 from 3.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_SD#18 from jerryneedell/jerryn_fix_byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix #17
I intentionally only added "& 0xff" where values are manipulated -- arguments passed into functions are assumed to be <= 0xff and need not be tested. If they are not, it is a legitimate error (e.g. crc, cmd, token) Is that correct od should we wrap everything in () & 0xff?
Tested on PyPortal and feather_nrf52840_express (with tot featherwing) -- ran slideshow from SD Card.