fix parsing error on lines like b'X-Geo-Block-List:' as received by github
#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Jan 25, 2020
There was a problem hiding this comment.
should work as before when the input contains ": " but correctly handle the case where split returns just 1 item instead of 2. Slightly confused as to why b'X-Geo-Block-List:' would trigger this condition, but I figured it out: the split includes the colon and the space, but the space isn't present in the (empty) X-Geo-Block-List.
|
yeah there's nothing after, and so split() gives an array of length 1 |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 26, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 3.0.0 from 2.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#54 from makermelissa/set_digit_raw Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#17 from ladyada/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now pre-fill the contents to an empty string