Skip to content

Update Requests Discord API example to use settings.toml #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Update Requests Discord API example to use settings.toml #136

merged 2 commits into from
Jul 21, 2023

Conversation

DJDevon3
Copy link
Contributor

One API at a time. @kattni my contributions that have API in the example file name are not included in any learn guides or documentation. This is a good way to take baby steps with the update to settings.toml by first changing all of my contributions over.

Most likely @FoamyGuy will be reviewing this one again. This is the web scrape example that requires you to get the auth key from the request header with a browser developer tool. Still works fine.

Unsure if I should embed the Web Workflow credentials for getenv in the example or just wifi?

DJDevon3 added 2 commits June 22, 2023 23:17
One API at a time. This should not affect any learn guides.  This is the web scrape example that requires you to get the auth key from the request header with a browser developer tool. Still works fine.
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested it successfully on a Feather S3 TFT 8.2.0-beta.0

@FoamyGuy
Copy link
Contributor

Thanks @DJDevon3!

@FoamyGuy FoamyGuy merged commit 36f1bb0 into adafruit:main Jul 21, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 22, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#130 from fasteddy516/fix_socket_swap
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#123 from BiffoBear/remove_ntp_client
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#122 from BiffoBear/fix_socket_leaks

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#136 from DJDevon3/WorkingBranch

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants