Skip to content

Use typing_extensions.Protocol if needed #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2022
Merged

Use typing_extensions.Protocol if needed #107

merged 3 commits into from
Mar 29, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Mar 29, 2022 •
edited
Loading

New black hated that space apparently 😖

Also took the opportunity to resolve #107

@tekktrik tekktrik requested a review from a team March 29, 2022 17:05
@tekktrik tekktrik marked this pull request as draft March 29, 2022 17:05
@tekktrik tekktrik marked this pull request as ready for review March 29, 2022 17:07
@tekktrik tekktrik changed the title Rerun new black version Use typing_extensions.Protocol if needed Mar 29, 2022
@tekktrik tekktrik mentioned this pull request Mar 29, 2022
Closed
dhalbert
dhalbert requested changes Mar 29, 2022
View reviewed changes
@tekktrik tekktrik requested a review from dhalbert March 29, 2022 17:19
dhalbert
dhalbert approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit 7ac2df5 into adafruit:main Mar 29, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 5, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d21f7d6)
dd538f5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_74HC595 to 1.3.5 from 1.3.4:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.13 from 1.2.12:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.11 from 2.6.10:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.0.5 from 5.0.4:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 3.0.5 from 3.0.4:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.5.3 from 1.5.2:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.4 from 0.6.3:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.4.1 from 1.4.0:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.4 from 4.1.3:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 3.3.0 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#50 from tekktrik/dev/use-bus-device
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.4.3 from 4.4.2:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX7219 to 1.5.3 from 1.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX7219#42 from tekktrik/doc/update-example-pins

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9600 to 1.2.4 from 1.2.3:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.12 from 3.3.11:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.0.10 from 2.0.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#31 from tekktrik/doc/add-typing
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD4X to 1.3.1 from 1.3.0:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLA202X to 1.0.6 from 1.0.5:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSC2007 to 1.0.1 from 1.0.0:
  > "Reformatted per new black version"

Updating https://github.com/adafruit/Adafruit_CircuitPython_TT21100 to 0.8.1 from 0.8.0:
  > "Reformatted per new black version"
  > Update Black to latest.
  > Corrected pylint version

Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 5.0.0 from 4.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#23 from FoamyGuy/doc_strings
  > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#22 from Neradoc/fix-documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.6.1 from 3.6.0:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L1X to 1.1.0 from 1.0.2:
  > "Reformatted per new black version"
  > Update Black to latest.
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L1X#3 from wrdaigle/main
  > Fixed readthedocs build

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.4.3 from 1.4.2:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.2.4 from 8.2.3:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet to 0.12.2 from 0.12.1:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_Colorsys to 2.0.5 from 2.0.4:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.1.4 from 1.1.3:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.1.7 from 1.1.6:
  > "Reformatted per new black version"
  > Update Black to latest.
  > Fixed readthedocs build
  > Post-patch cleanup pt2
  > Post-patch cleanup
  > Consolidate Documentation sections of README
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_Ducky to 1.0.4 from 1.0.3:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.5.15 from 2.5.14:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.1.1 from 2.1.0:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.12 from 0.2.11:
  > "Reformatted per new black version"
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniQR to 1.3.9 from 1.3.8:
  > "Reformatted per new black version"
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.6.3 from 0.6.2:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.11.5 from 1.11.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#69 from tekktrik/dev/fix-doc-building
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 3.6.4 from 3.6.3:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.11.2 from 1.11.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#107 from tekktrik/doc/rerun-black
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.7.5 from 1.7.4:
  > "Reformatted per new black version"
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.3.11 from 1.3.10:
  > "Reformatted per new black version"
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README
@tekktrik tekktrik deleted the doc/rerun-black branch September 7, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tekktrik @dhalbert