Skip to content

Make version a valid semver. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2019
Merged

Make version a valid semver. #3

merged 1 commit into from
Sep 6, 2019

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Sep 6, 2019

So circup complain that the version is not valid semver. This minor PR corrects this problem. Thanks!

@ladyada ladyada merged commit 63d26ad into adafruit:master Sep 6, 2019
@ladyada
Copy link
Member

ladyada commented Sep 6, 2019

@brentru

@brentru
Copy link
Member

brentru commented Sep 9, 2019

@ladyada The __version__ in __init__.py does not match the release version, since it's the python-rsa package version.
Should the release version for this library follow the python-rsa version, or should I submit a PR to update this version string to match the CircuitPython_RSA library version?

@tannewt
Copy link
Member

tannewt commented Sep 9, 2019

@brentru comment out the old __version__ and add the appropriate __version__ and __repo__ to every file for CircuitPython consistency please. It's a CircuitPython library now. :-)

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 9, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@62c4c36)
2d8c606 
Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_RSA#4 from brentru/update-version-repo
  > Merge pull request adafruit/Adafruit_CircuitPython_RSA#3 from ntoll/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_PCT2075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ntoll @ladyada @brentru @tannewt