Skip to content

Add type annotations #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2022
Merged

Add type annotations #23

merged 4 commits into from
Mar 14, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Mar 3, 2022

Resolves #21 by adding type annotations!

@tekktrik tekktrik requested a review from a team March 3, 2022 04:51
FoamyGuy
FoamyGuy approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @tekktrik.

Don't have hardware to test, but looked over and did not find any changes beyond types and docstrings, would not anticipate any change in functionality.

@FoamyGuy FoamyGuy merged commit 5133e6a into adafruit:main Mar 14, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 15, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@8ce3914)
572e3d4 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.12 from 1.2.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#37 from tekktrik/doc/add-init-params

Updating https://github.com/adafruit/Adafruit_CircuitPython_RPLIDAR to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_RPLIDAR#23 from tekktrik/doc/add-typing
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.3.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#15 from Nico04/power_state
  > Fixed readthedocs build
  > Post-patch cleanup
  > Consolidate Documentation sections of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tekktrik @FoamyGuy