First code copied from Skoltech repo #1
Conversation
|
looks great so far - let me know when you want 👁 review/suggestions! |
|
@ladyada This works fine opn the Pi with CPython using the USB interface. But reading from the UART under CP seems to be returning random bytes. |
|
huh thats odd, well we will have to figure that part out when we use it on an M4 |
|
Yeah, that on an M4. |
|
@kattni When you have a chance. |
There was a problem hiding this comment.
Thanks for doing this up! It appears you may have run the initial cookiecutter quite a while ago as we have made some important changes to it since you may have run it. Please run cookiecutter again and copy:
.travis.ymlsetup.py
Then replace the current versions in this repo with the two new files generated by cookiecutter.
As well, please populate the rplidar_simpletest.py file in examples. It is currently empty. As there is nothing in the file, I cannot add an inline comment there, so I'm including it here.
README.md
Outdated
| ## Introduction ## |
There was a problem hiding this comment.
You shouldn't have two READMEs. The README.rst is the one rendered by RTD, and is the one we use. Please transfer any information you wish to keep from this README to the README.rst file and delete the README.md file.
setup.py
Outdated
| @@ -0,0 +1,21 @@ | |||
| import setuptools | |||
There was a problem hiding this comment.
Where did you get this setup.py? Do you intend to have this on PyPI through Travis the way we have done with every other library? If so, this is not a sufficient file.
| @@ -0,0 +1,33 @@ | |||
| # This is a common .travis.yml for generating library release zip files for | |||
There was a problem hiding this comment.
This is not the most recent version of .travis.yml. Please update it.
|
@dastels - please correct any link to the code in the guide. |
No description provided.