Skip to content

Update example for 1.14" TFT users. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Conversation

chfw
Copy link
Contributor

@chfw chfw commented Apr 12, 2020

The usage example may only work for 2.2", 2.4", 2.8", 3.2" TFT ( which I could not verify ). With 1.14" TFT and raspberry pi 4, the wiring are different, chipset driver is different.

At the first try-out, as a novice user, I was doubting my soldering skills. Why does not it work? Blank screen! It turns out that wrong chipset driver was used.

After updating its chipset driver, it is still blank! I was doubting my connections and my soldering skills again! It turns out that the CS_PIN, DC_PIN are not the same as bigger TFTs.

After referencing the great example, it worked. Hence, could I save a few hours of next 1.14" TFT users please?

chfw added 2 commits April 12, 2020 23:03
The usage example may only work for 2.2", 2.4", 2.8", 3.2" TFT ( which I could not verify ). With 1.14" TFT and raspberry pi 4, the wiring are different, chipset is different. 

At the first try-out, as a novice user, I was doubting my soldering skills. Why does not it work? Blank screen! It turns out that wrong chipset driver was used. 

After updating its chipset driver, it is still blank! I was doubting my connections and my soldering skills again! It turns out that the CS_PIN, DC_PIN are not the same as bigger TFTs.

After all those adjustments, it worked.
with this fix, the blue rectangle will situate at the corner near Vin pin.
@chfw
Copy link
Contributor Author

chfw commented Apr 12, 2020

Please do a squash merge! I missed x and y offsets after verifying it on my display.

@chfw
Copy link
Contributor Author

chfw commented Apr 12, 2020

Here is the display in action:

Screenshot 2020-04-12 at 23 14 35

@ladyada ladyada requested a review from makermelissa April 12, 2020 22:50
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for adding this. For the guide link, perhaps change it to https://learn.adafruit.com/adafruit-1-14-240x135-color-tft-breakout/python-wiring-and-setup since you are specifically mentioning the 1.14" display. It's a mirror of the same page you linked to, but is in the 1.14" guide in case users want to see other related pages.

address review feedback.
@chfw chfw requested a review from makermelissa April 13, 2020 18:33
@chfw
Copy link
Contributor Author

chfw commented Apr 13, 2020

Well spotted!

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@makermelissa makermelissa merged commit be66e26 into adafruit:master Apr 20, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants