-
Notifications
You must be signed in to change notification settings - Fork 5
Add typing #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add typing #23
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
962c75c
Made the typing of the pins more explicit, so it's clear where they c…
0790d55
Removed extra copy of doc string from color property.
fac3aa7
Merge branch 'main' into Add_typing
ec15648
Rolled back changes to Sphinx and moved to types in string quotes.
61f89d2
Moved doc-string from __init__ to class definition.
8ffdd79
Refactored typing to use ColorBasedColorUnion.
430c6af
Refactored Pin to microcontroller.Pin.
89c3643
Refactored Pin to "microcontroller.Pin".
588a0d1
Changed import of TracebackType from typing to types.
3b711a1
Attempt to fix docstring indent.
2653b83
Added adafruit_circuitpython_typing~=1.4 to requirements.txt.
af553d3
Imported microcontroller.Pin and adafruit_pca9685.PWMChannel
5d50d92
Removed PWMChannel import as it fails CI.
0ac3968
Added adafruit_pca9685 to requirements.txt and imported for typing.
9fe37bb
Removed adafruit_pca9685 from requirements.txt and wrapped quotes aro…
5996fd2
Added adafruit_pca9685 back to requirements.txt.
2a17b3c
Renamed adafruit_pca9685 to Adafruit-PCA9685, adafruit-circuitpython-…
f5d9e06
fix requirement pip name
FoamyGuy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason you're using quotes instead of importing within the
try
/except
block?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the "microcontroller.Pin" I was getting "Not Implemented" exceptions in my PyCharm environment. That now happens with the
from pwmio import PWMOut
which makes this moot. I've changed this to usefrom microcontroller import Pin
For the "PWMChannel" I couldn't find a library with
PWMChannel
that I can import on my laptop. The#circuitpython-dev
Discord channel suggested using quotes. If you know of a library that I can use, I'm happy to make that change too.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…and the CI is failing with
Which may be why I used the quotes. Can't remember TBH!
adafruit-blinka
is inrequirements.txt
and that's where I thought themicrocontroller
module lives.I'll push a commit with quotes to have something that passes the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it's failing because it isn't actually imported in the file. If you add it as an import to the
try
/except
block, it should work fine without quotes. Same thing forPWMChannel
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With import statements in the
try/except
block I can getPin
to pass CI but notPWMChannel
.I've added
adafruit-pca9685
torequirements.txt
but this did not help.