Fix sleep delay for M4 - fix example for RPi #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should fix #8 |
ladyada
approved these changes
Aug 28, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 29, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#10 from jerryneedell/jerryn_sleep > ignore the board module imports in .pylintrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delay after entering "sleep" mode needed to be moved to immediately after the self.sleep() call. On the M4, the board was not entering sleep mode before the next configuration instructions were being received.
Removed the unnecessary commented out code.
In rfm9x_simpletest.py -- converted the test message string to a bytesring - this is needed for the Raspberry Pi Python to execute. It also works for CircuitPython.
Tested on:
Feather M4 Express
Feather M0 Express
Raspberry Pi 3B+