fix frequency setter and misc items #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Jul 10, 2018
README.rst
Outdated
| The baud rate may be specified as an keyword parameter when initializing the board. | ||
| To set it to 1000000 use : | ||
| .. code-block:: python# Initialze RFM radio | ||
| .. code-block:: python |
| # Go back to idle mode after transmit. | ||
| self.idle() | ||
| if timed_out: | ||
| raise RuntimeError('Timeout during packet send') |
adafruit_rfm69.py
Outdated
| # Listen again if necessary and return the result packet. | ||
| if keep_listening: | ||
| self.listen() | ||
| if not timed_out: |
There was a problem hiding this comment.
Invert this and return None early. That simplifies the code below it
jerryneedell
commented
Jul 10, 2018
README.rst
Outdated
| .. code-block:: python | ||
| # Initialze RFM radio | ||
| rfm9x = adafruit_rfm9x.RFM9x(spi, CS, RESET, RADIO_FREQ_MHZ,baudrate=1000000) | ||
|
|
There was a problem hiding this comment.
Clearly, am not formatting this correctly -- What am I doing wrong?
|
@tannewt Are there more changes needed? Let me know if I missed something. |
tannewt
approved these changes
Jul 16, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 19, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 1.1.3 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#8 from jerryneedell/jerryn_fixpylint > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#7 from jerryneedell/jerryn_fix_freq Updating https://github.com/adafruit/Adafruit_CircuitPython_STMPE610 to 1.0.1 from 0.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#5 from jerryneedell/jerryn_fixpylint > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#4 from jerryneedell/jerryn_fixspi > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#2 from adafruit/tannewt-patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the frequency setter to correctly set fewquency_mhz.
I also added a timeout to the send function to avoid a potential hang.
the parameters to set the send/receive timeouts were renamed from timeout_s to timeout to be compatible with the standard naming conventions.
The deafault SPI baudrate was lowered to 5MHz as was done for the RF95x to avoid problems with the breakout boards.
Note : I cannot make any sense of the RSSI readings from this module. I did not change the way they are reported and this issue was present in the current release, but the values reported are much lower than expected and much lower than those reported by Arduino.
I tested this with both an RFM69HCW featherwing and an RFM69HCW breakout board