Update show_QR #31
Merged
Update show_QR #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
May 2, 2019
|
ill take anything cause current code isnt working at all :D |
|
Sure. Was this suppose to be any fancier than just "clear screen and show QR code"? |
|
its pretty simple, yeah |
|
Generally works. This: Adafruit CircuitPython 4.0.0-rc.1 on 2019-04-23; Adafruit PyPortal with samd51j20
>>> from adafruit_pyportal import PyPortal
>>> pp = PyPortal()
ESP firmware: bytearray(b'1.2.2\x00')
Set background to 0
No SD card found: no SD card
>>> pp.show_QR(b'hello world', 8, 20, 20)gives this: Note weird border quirk might be related to this: |
|
fine by me! |
|
@ladyada want me to version bump this? |
|
yes plz! |
|
Done! Bumped major ver since the function call changed. |
|
amazing, thank you thank you carter :) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 3, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.1.0 from 3.0.10: > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#13 from jraber/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.0.0 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#31 from caternuson/iss30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an idea for #30