Added headers parameter to network.fetch call #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
approved these changes
Feb 18, 2021
|
It looks like the same issue exists in the Blinka_PyPortal repo, which I can add. |
This was referenced Feb 18, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 19, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#51 from adafruit/REUSE > Hardcoded Black and REUSE versions > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1841 to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_DS1841#3 from adafruit/REUSE > Hardcoded Black and REUSE versions > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS2X to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_LPS2X#6 from adafruit/REUSE > Hardcoded Black and REUSE versions > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.4.4 from 2.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#39 from SAK917/master Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel_SPI to 0.9.1 from 0.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel_SPI#27 from adafruit/REUSE > Hardcoded Black and REUSE versions > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 5.1.4 from 5.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#107 from kimmellr/request-header-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TM#2 from imgrant/serial_number Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Eddystone to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Eddystone#11 from adafruit/REUSE Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_iBBQ to 1.2.3 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_iBBQ#4 from adafruit/REUSE > Hardcoded Black and REUSE versions > Added pre-commit-config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header parameter was not being passed to the network.fetch call. This broke any request that required a authentication header to retrieve data (i.e. Twitter)
I added headers=self._headers to the network.fetch call and tested with the Twitter API.