-
Notifications
You must be signed in to change notification settings - Fork 25
Set pixels brightness; recall display brightness setting in auto dim mode #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Travis errors are completely Greek to me. I'll need some help with this one. |
Ah, that's an easy one. As it suggests, add 12 spaces to the left of that statement. :) |
Thanks! Where can I find the Travis details (asked the newbie)? |
On the checks tab. |
Thanks @makermelissa. The browser app's checks tab didn't have that level of detail. Saw that pylint can be used to reveal the details. May be time to switch to Linux. |
adafruit_pybadger.py
Outdated
@@ -103,6 +103,7 @@ def __init__(self, i2c=None): | |||
|
|||
# Display | |||
self.display = board.DISPLAY | |||
self._brightness_value = 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a value for display brightness. Can we name it something like _display_brightness so it doesn't get confused with neopixel brightness? It makes reading the code a bit easier. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent idea. I'll make the change.
Sorry, I meant under the Checks tab, you need to click the link labeled "The Build" and it should get you there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3731 to 2.5.2 from 2.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#19 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#18 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#17 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3731#16 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.9.4 from 0.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#11 from CedarGroveStudios/master
brightness=1.0
when restoring to initial brightness withauto_dim_display()
: