Skip to content

Changes for the Blinka not having rtc or supervisor #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

Changes for the Blinka not having rtc or supervisor #9

merged 1 commit into from
Jan 14, 2021

Conversation

makermelissa
Copy link
Collaborator

These changes are needed to work on CPython.

@makermelissa makermelissa requested a review from a team January 14, 2021 23:03
gamblor21
gamblor21 approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but looking it over, looks good. Only thought on RTC will it confuse blinka users if they call to set the date and it isn't set? The function does not return a date at all.

@makermelissa
Copy link
Collaborator Author

Thanks. No, it isn't settable through Python, so the existing Blinka PyPortal behaves exactly like the get_local_time function without the rtc code.

@makermelissa
Copy link
Collaborator Author

Also, this is not really testable by reviewers because I'm refactoring still.

@makermelissa makermelissa merged commit 5c5b54d into adafruit:main Jan 14, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 15, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@0b83e6e)
8da44ff 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#29 from benetherington/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#30 from adafruit/REUSE
  > Added pre-commit-config file
  > Added pre-commit and SPDX copyright

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#9 from makermelissa/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamblor21 gamblor21 gamblor21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makermelissa @gamblor21