Refactoring to save memory #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Aug 28, 2018
|
looks good to me, does that help with mem? |
|
Seems to. I added more info in issue thread. #3 |
|
OK, now it's just failing on the examples. I'll update those once this has been tested a little more. |
|
@caternuson This ready to go in now? |
|
I tested with Trinket M0 and Metro M4. I'm good, but I think @ladyada was going to do some more testing: |
|
thanks for waitin' i tested this on M4 with all modes with success! :) |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 17, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_PN532 to 2.0.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_PN532#6 from caternuson/iss3_refactor > Merge pull request adafruit/Adafruit_CircuitPython_PN532#5 from caternuson/iss4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the individual subclasses into their own modules and put in subfolder.
The examples have not been updated for this layout
Old usage:
New usage (i2c):