-
Notifications
You must be signed in to change notification settings - Fork 18
Move import to I2C only section #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Move the import (next pylint will have to ignore this
This seems to work as far as I can test... but it is supposed to be not recommended. And next I need to fight pylint...
This keep pylint happy.
This is Black recommendation... not sure I like it.
I have to cheat for both.
Why do this? If for memory saving, I'd prefer to move this library to a package with separate modules (aka files) for i2c and uart. |
I did this because of issue #5 and I got multiple suggestions on how to do it. So I gave this a try. I am happy with "not fixing this", I would have learn to fight against Pylint and Black when they do not aggree. Also there is a bit of OO Python here, with a "super class" that use the I2C or UART for implementation detail, and I don't know how that work accross separated files. |
Up to you if you want to continue. Below I've outlined the steps.
|
I also have #6 pending. When that is fix, I can try to split I2C from UART in separate files... But I don't want to make two incompatible PR. |
Ok, I merged #6. Sorry for the delay. |
I'm closing this in favor of #8. |
Move the import (next pylint will have to ignore this