Rewrite parser #43
Closed
Rewrite parser #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: adafruit#30 (though I don't know what octal syntax is accepted by official pioasm, we will accept python-style 0o567 not C-style 0567)
This passes all tests, with many error messages improved. Most errors
now show their context, such as
```
adafruit_pioasm.ParseError: Line 1, column 5: Jump to undefined label undef
jmp undef
^
adafruit_pioasm.ParseError: Line 1, column 5: Expected 'pins', 'x', 'y', None, 'exec', 'pc', 'isr', 'osr'
mov hello
^
```
debuginfo is not supported.
This should set the stage for adding expression parsing and
supporting ".define".
Closes #405
|
This incarnation sort of mashes together tokenization & recursive-descent parsing without lookahead. Implementing operator precedence becomes a bit puzzling in this design, so maybe another design needs to be tried. |
|
I don't have plans to work on this at the moment, so closing it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement pioasm
This passes all tests, with many error messages improved. Most errors now show their context, such as
This should set the stage for adding expression parsing and supporting ".define".
Closes #40