Improve doc for ntp.datetime access behavior and exceptions #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askpatrickw
approved these changes
Sep 5, 2022
|
Looks good, ty! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 10, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 3.0.13 from 3.0.12: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#58 from adafruit/license-switch > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#57 from adafruit/adding-bmps > Moved advanced remote up one directory Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.4 from 5.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#173 from tekktrik/dev/add-optional-reqs Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.0.7 from 3.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#24 from jdimpson/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.4 from 1.14.3: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#82 from tekktrik/dev/error-passthrough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some words to the inline documentation about both how 1) accesses to
ntp.datetimeactually cause the NTP request to be sent, and therefore 2) accesses tontp.datetimemay throw anOSErrorexception, which should be caught and handled appropriately