Skip to content

[#18] Add type annotations #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2021
Merged

[#18] Add type annotations #19

merged 2 commits into from
Oct 10, 2021

Conversation

process1183
Copy link
Contributor

Added missing type annotations to the methods in the NTP class.

@process1183 process1183 mentioned this pull request Oct 7, 2021
Closed
2 tasks
@FoamyGuy
Copy link
Contributor

FoamyGuy commented Oct 7, 2021

Thanks for working on this @process1183 I'll look over this later on tonight.

@FoamyGuy FoamyGuy self-requested a review October 7, 2021 13:56
FoamyGuy
FoamyGuy reviewed Oct 7, 2021
View reviewed changes
FoamyGuy
FoamyGuy approved these changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Tested successfully the simpletest example on:

Adafruit CircuitPython 7.0.0-rc.1 on 2021-09-02; Adafruit PyPortal with samd51j20
Board ID:pyportal

@FoamyGuy FoamyGuy merged commit b08454f into adafruit:main Oct 10, 2021
@process1183 process1183 deleted the type_annotations branch October 10, 2021 20:22
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 11, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b005706)
3141fbe 
Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 2.2.4 from 2.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_NTP#19 from process1183/type_annotations
  > Globally disabled consider-using-f-string pylint check
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_OV5640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@process1183 @FoamyGuy